Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write early hints to browser #420

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

digitalsadhu
Copy link
Member

@digitalsadhu digitalsadhu commented Sep 18, 2024

Phase 2.
Write the early hints from the podlet, out to the browser. Once again, backwards compatible, no breaking changes.

Copy link
Contributor

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this would work 💪

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@wkillerud wkillerud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about some of the test assertions, otherwise just nitpicks

lib/resolver.js Outdated Show resolved Hide resolved
tests/http-outgoing.test.js Outdated Show resolved Hide resolved
tests/resolver.content.test.js Outdated Show resolved Hide resolved
tests/resolver.content.test.js Outdated Show resolved Hide resolved
tests/http-outgoing.test.js Outdated Show resolved Hide resolved
tests/http-outgoing.test.js Outdated Show resolved Hide resolved
@digitalsadhu digitalsadhu merged commit 310204e into next Sep 20, 2024
7 checks passed
@digitalsadhu digitalsadhu deleted the write_early_hints_to_browser branch September 20, 2024 01:31
Copy link

🎉 This PR is included in version 5.2.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants