Drop early hints, use headers to send links instead. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
leftieFriele,
wkillerud,
trygve-lie,
tor0405 and
flatoy
and removed request for
leftieFriele
wkillerud
approved these changes
Oct 15, 2024
leftieFriele
approved these changes
Oct 15, 2024
|
🎉 This PR is included in version 5.2.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the client so that when assets are sent via link headers from the podlet, they are grabbed and converted to asset objects by the client and then emitted with the beforeStream event (for the .stream() method) or just returned with the response (for the .fetch() method). Early hints is removed.