feat: track podlet assets #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
wkillerud,
leftieFriele,
trygve-lie,
tor0405 and
flatoy
and removed request for
wkillerud
wkillerud
approved these changes
Nov 12, 2024
|
🎉 This PR is included in version 5.3.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for asset tracking for use when doing streaming responses.
The idea is that whenever .fetch or .stream is called, we add the request to our list of tracked requests and then we tick them off as we get responses from podlets. Once all requests are accounted for a given http request, the HTTPIncoming.hints object will fire a "complete" event which can be listened for in order to know when we have all podlet assets and can build and send a document head to the browser.
The underlying hints apis naming needs changing in the HTTPIncoming class since we are no longer using 103 hints.