Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Pre-sort groups in group-by-dynamic #21569

Merged
merged 1 commit into from
Mar 3, 2025
Merged

perf: Pre-sort groups in group-by-dynamic #21569

merged 1 commit into from
Mar 3, 2025

Conversation

ritchie46
Copy link
Member

Same as #21403

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

The uncompressed lib size after this PR is 41.6629 MB.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (5b6a7b7) to head (8d5449a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...olars-mem-engine/src/executors/group_by_rolling.rs 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21569      +/-   ##
==========================================
+ Coverage   79.59%   79.60%   +0.01%     
==========================================
  Files        1591     1591              
  Lines      229520   229268     -252     
  Branches     2632     2632              
==========================================
- Hits       182680   182506     -174     
+ Misses      46233    46155      -78     
  Partials      607      607              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5766283 into main Mar 3, 2025
22 of 23 checks passed
@ritchie46 ritchie46 deleted the dynamic branch March 3, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant