-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subset.as_dataframe()
hides targets instead of raising an error
#258
Conversation
Resolves polaris-hub#257
That was fast! 😅 Thanks @JacksonBurns! Would you mind adding a test case to make sure the |
review comment: polaris-hub#258 (comment)
@cwognum sure thing, done |
@JacksonBurns Just wanted to let you know that we're looking into why the CICD is failing here... I believe you're our first external contributor, so things may be breaking in new ways! 😅 |
Happy to be 'breaking' new ground, as it were |
Hi @JacksonBurns . Thanks for contributing. It seems our CI pipeline is having some issues unrelated to your PR. I'm looking into it. |
Hi @JacksonBurns. Could you rebase your fork, or merge the new changes in our main? That will fix the issue you're encountering with the CI. It was indeed an issue related to pull requests coming in from forks of the repo. The failing tests should be skipped for you now. |
Just merged in the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @JacksonBurns ! 🙏
Changelogs
Subset.as_dataframe()
would raise an error when called on a test set (which hides its targets), this PR allows method to work, just doesn't return targestChecklist:
feature
,fix
,chore
,documentation
ortest
(or ask a maintainer to do it for you).Resolves #257