Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset.as_dataframe() hides targets instead of raising an error #258

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

JacksonBurns
Copy link
Contributor

@JacksonBurns JacksonBurns commented Jan 29, 2025

Changelogs

  • Subset.as_dataframe() would raise an error when called on a test set (which hides its targets), this PR allows method to work, just doesn't return targest

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Resolves #257

Sorry, something went wrong.

@JacksonBurns JacksonBurns requested a review from cwognum as a code owner January 29, 2025 18:37
@cwognum
Copy link
Collaborator

cwognum commented Jan 29, 2025

That was fast! 😅

Thanks @JacksonBurns! Would you mind adding a test case to make sure the as_dataframe() method returns the expected results for the train and test set?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
review comment: polaris-hub#258 (comment)
@JacksonBurns
Copy link
Contributor Author

@cwognum sure thing, done

@cwognum cwognum added the feature Annotates any PR that adds new features; Used in the release process label Jan 29, 2025
@cwognum
Copy link
Collaborator

cwognum commented Jan 30, 2025

@JacksonBurns Just wanted to let you know that we're looking into why the CICD is failing here... I believe you're our first external contributor, so things may be breaking in new ways! 😅

@JacksonBurns
Copy link
Contributor Author

Happy to be 'breaking' new ground, as it were

@jstlaurent
Copy link
Contributor

Hi @JacksonBurns . Thanks for contributing. It seems our CI pipeline is having some issues unrelated to your PR. I'm looking into it.

@jstlaurent
Copy link
Contributor

Hi @JacksonBurns. Could you rebase your fork, or merge the new changes in our main? That will fix the issue you're encountering with the CI. It was indeed an issue related to pull requests coming in from forks of the repo. The failing tests should be skipped for you now.

@JacksonBurns
Copy link
Contributor Author

Just merged in the changes!

Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @JacksonBurns ! 🙏

@jstlaurent jstlaurent merged commit fe3bff3 into polaris-hub:main Jan 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Annotates any PR that adds new features; Used in the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test.as_dataframe shouldn't raise an error
3 participants