Skip to content
revive

fix:修复熔断规则atomic.Value使用存在panic问题 #251

Sign in to view logs

fix:修复熔断规则atomic.Value使用存在panic问题

fix:修复熔断规则atomic.Value使用存在panic问题 #251

Triggered via pull request December 18, 2023 13:57
@chuntaojunchuntaojun
synchronize #191
chuntaojun:feat/fault_detect
Status Success
Total duration 1m 32s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

60 warnings
Run Revive Action (1.15.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.15.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.15.x): plugin/location/remotehttp/remotehttp.go#L18
should have a package comment
Run Revive Action (1.15.x): api_config.go#L111
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.15.x): plugin/healthcheck/tcp/config.go#L18
should have a package comment
Run Revive Action (1.15.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.15.x): test/common/constant.go#L18
should have a package comment
Run Revive Action (1.15.x): plugin/metrics/prometheus/reporter.go#L130
redundant if ...; err != nil check, just return error instead.
Run Revive Action (1.16.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.16.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.16.x): plugin/weightadjuster/ratedelay/ratedelay.go#L58
parameter 'service' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): test/all_suite_test.go#L33
should not use dot imports
Run Revive Action (1.16.x): test/common/constant.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.16.x): plugin/ratelimiter/reject/bucket.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/ratelimiter/model.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.18.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.18.x): test/loadbalance/discover_lb.go#L52
parameter 'c' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): plugin/logger/zaplog/logger.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.18.x): plugin/metrics/prometheus/config.go#L17
should have a package comment
Run Revive Action (1.18.x): test/loadbalance/discover_lb.go#L84
parameter 'c' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): test/loadbalance/loadbalance_suite.go#L106
parameter 'c' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.20.x): examples/ratelimit/provider/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/interface/consumer/main.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/maglev/config.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/interface/provider/main.go#L17
should have a package comment
Run Revive Action (1.20.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/route/dynamic/provider/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/route/nearby/consumer/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/quickstart/consumer/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
Run Revive Action (1.17.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/watch/instance/notify/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/configconnector/config_connector.go#L19
should have a package comment
Run Revive Action (1.17.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.17.x): test/common/constant.go#L21
exported const ConsumerSuitServerPort should have comment (or a comment on this block) or be unexported
Run Revive Action (1.17.x): plugin/location/local/local.go#L35
exported function New should have comment or be unexported
Run Revive Action (1.17.x): test/all_suite_test.go#L33
should not use dot imports
Run Revive Action (1.17.x): plugin/location/remotehttp/remotehttp.go#L33
exported function New should have comment or be unexported
Run Revive Action (1.19.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.19.x): examples/watch/service/longpull/main.go#L77
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.19.x): examples/watch/instance/notify/main.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/stat/loadbalance/lb.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/stat/plugin/plug.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/weightadjuster/ratedelay/ratedelay.go#L18
should have a package comment
Run Revive Action (1.19.x): test/common/constant.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported