Skip to content
revive

fix:修复熔断规则atomic.Value使用存在panic问题 #253

Sign in to view logs

fix:修复熔断规则atomic.Value使用存在panic问题

fix:修复熔断规则atomic.Value使用存在panic问题 #253

Triggered via pull request December 18, 2023 14:03
@chuntaojunchuntaojun
synchronize #191
chuntaojun:feat/fault_detect
Status Success
Total duration 1m 12s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

60 warnings
Run Revive Action (1.16.x): examples/watch/instance/longpull/main.go#L88
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.16.x): examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.16.x): examples/watch/instance/notify/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L48
comment on exported method TestListener.OnServicesUpdate should be of the form "OnServicesUpdate ..."
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/quickstart/consumer/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/circuitbreaker/interface/consumer/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.15.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/algorithm/rand/scalable_rand_test.go#L51
parameter 't' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/circuitbreaker/proxy.go#L32
comment on exported method Proxy.CheckResource should be of the form "CheckResource ..."
Run Revive Action (1.15.x): pkg/flow/registerstate/register_flow.go#L71
exported method PutRegister returns unexported type *registerstate.registerState, which can be annoying to use
Run Revive Action (1.15.x): pkg/model/local/value.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.18.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/circuitbreaker/circuitbreaker.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/common/plugin.go#L18
should have a package comment
Run Revive Action (1.17.x): test/util/namesuite.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/circuitbreaker/circuitbreaker.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/circuitbreaker/proxy.go#L32
comment on exported method Proxy.CheckResource should be of the form "CheckResource ..."
Run Revive Action (1.17.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.17.x): examples/circuitbreaker/interface/consumer/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/circuitbreaker/interface/provider/main.go#L17
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/circuitbreaker/proxy.go#L37
comment on exported method Proxy.Report should be of the form "Report ..."
Run Revive Action (1.17.x): plugin/localregistry/inmemory/inmemory.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): plugin/localregistry/common/cache_persist.go#L82
redundant if ...; err != nil check, just return error instead.
Run Revive Action (1.19.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/maglev/config.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/maglev/maglev.go#L32
type name will be used as maglev.MaglevLoadBalancer by other packages, and that stutters; consider calling this LoadBalancer
Run Revive Action (1.19.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.20.x): plugin/location/remoteservice/remoteservice.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/quickstart/consumer/main.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/location/remoteservice/remoteservice.go#L35
exported function New should have comment or be unexported
Run Revive Action (1.20.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.20.x): plugin/location/remotehttp/remotehttp.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/logger/zaplog/logger.go#L18
should have a package comment