Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] plugin/circuitbreaker/composite/rule.go中rule.RuleMatcher.Destination.Method为nil的问题 #206

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[fix] plugin/circuitbreaker/composite/rule.go中rule.RuleMatcher.Destination.Method为nil的问题 #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/circuitbreaker/composite/rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,18 +210,18 @@ func sortCircuitBreakerRules(rules []*fault_tolerance.CircuitBreakerRule) []*fau
// 1. compare destination service
destNamespace1 := rule1.RuleMatcher.Destination.Namespace
destService1 := rule1.RuleMatcher.Destination.Service
destMethod1 := rule1.RuleMatcher.Destination.Method.Value.Value

destNamespace2 := rule2.RuleMatcher.Destination.Namespace
destService2 := rule2.RuleMatcher.Destination.Service
destMethod2 := rule2.RuleMatcher.Destination.Method.Value.Value

svcResult := compareService(destNamespace1, destService1, destNamespace2, destService2)
if svcResult != 0 {
return svcResult < 0
}
if rule1.Level == rule2.Level {
if rule1.Level == fault_tolerance.Level_METHOD {
destMethod1 := rule1.RuleMatcher.Destination.Method.Value.Value
destMethod2 := rule2.RuleMatcher.Destination.Method.Value.Value
methodResult := compareStringValue(destMethod1, destMethod2)
if methodResult != 0 {
return methodResult < 0
Expand Down
Loading