Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Set Up Validator #257

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Improve Set Up Validator #257

merged 7 commits into from
Jan 22, 2025

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Dec 13, 2024

This page addresses some issues in the Set Up a Validator page

Co-authored-by: Nicolás Hussein <[email protected]>
@BulatSaif
Copy link

Not related to changes in this PR, but general improvements for the set-up-validator.md page:

  1. In the Install from Official Releases section:
    Add a step to check the signature after downloading the binary from GitHub.

  2. In the Generate Session Keys section:
    There are many ways to generate and inject keys (I know at least 5). Polkadot.js Apps UI and CLI (curl) are the "back-magic" methods. I like KILT instruction it includes manual generation Subkey, which can help explain how the keys are generated and stored. KILT Docs: Generating Session Keys.

@0xLucca
Copy link
Collaborator Author

0xLucca commented Jan 10, 2025

Not related to changes in this PR, but general improvements for the set-up-validator.md page:

  1. In the Install from Official Releases section:
    Add a step to check the signature after downloading the binary from GitHub.
  2. In the Generate Session Keys section:
    There are many ways to generate and inject keys (I know at least 5). Polkadot.js Apps UI and CLI (curl) are the "back-magic" methods. I like KILT instruction it includes manual generation Subkey, which can help explain how the keys are generated and stored. KILT Docs: Generating Session Keys.

Thanks @BulatSaif. I'll check your suggestions and add them to the page

@0xLucca 0xLucca marked this pull request as ready for review January 15, 2025 12:22
@0xLucca 0xLucca requested a review from a team as a code owner January 15, 2025 12:22
@0xLucca
Copy link
Collaborator Author

0xLucca commented Jan 15, 2025

I will add the checksum verification in this PR. Then, I will create a new one to split this page into multiple ones and add the key management suggested because the page is too long

@0xLucca 0xLucca added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Jan 15, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben
Copy link
Collaborator

eshaben commented Jan 17, 2025

@0xLucca there are some open convos. If everything has been addressed, please update Needs Review label to Ready to Merge

@0xLucca 0xLucca added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 17, 2025
@eshaben eshaben merged commit 501e284 into master Jan 22, 2025
1 check passed
@eshaben eshaben deleted the 0xlucca/improve-set-up-validator branch January 22, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants