Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Substrate.io Migration] Tutorials -> Build a Parachain -> Transfer Assets with XCM #30

Merged
merged 72 commits into from
Oct 4, 2024
Merged

[Substrate.io Migration] Tutorials -> Build a Parachain -> Transfer Assets with XCM #30

merged 72 commits into from
Oct 4, 2024

Conversation

nhussein11
Copy link
Collaborator

The "Transfer assets with XCM" page was migrated from the existing Substrate.io Tutorial section:
https://docs.substrate.io/tutorials/build-a-parachain/transfer-assets-with-xcm/

@nhussein11
fix: adding prepare substrate relay chain
1a523ef
@nhussein11
fiox: formatting error
a59e5e3
@nhussein11
fix: description
d5cc084
@nhussein11
fix: paraphrasing
5e7a4dc
@nhussein11
fix: vale warning
2413eec
@nhussein11
fix: formatting
291a833
@nhussein11
fix: adding conclusion to the tutorial
3b73da1
@nhussein11
fix: formatting
fabc617
@nhussein11
fix: formatting
5316122
@nhussein11
git: adding intro and build the parachain template section
763f598
@nhussein11
fix: adding wip
d27184f
@nhussein11
fix: updating prepare relay chain output and commands
ff83f15
@nhussein11
Merge branch 'nhussein11/tutorials-substrate-prepare-relay-chain' int…
339514f 
…o nhussein11/tutorials-substrate-connect-a-parachain
@nhussein11
fix: adding build a parachain complete process
907bff6
@nhussein11
fix: vale suggestion
75d518f
@nhussein11
fix: adding acquire a slot on testnet wip
77509c5
@nhussein11
fix: adding admin account example
a83ddde
@nhussein11
fix: typos
a956e4a
@nhussein11
fix: typo
2a7f3b3
@nhussein11
fix: typo
010a96d
@nhussein11
fix: formatting
4d2296c
@nhussein11
fix: formatting
5f7a28c
@nhussein11
fix: typo and adding abs route to build a local blockchain tutorial
213814e
@nhussein11
fix: paraphrasing
1286b44
@nhussein11
fix: updating deprecated route
4f2a152
@nhussein11
fix: paraphrasing
f8b1fa8
@nhussein11
fix: formatting
1cb5f77
@nhussein11
fix: chain specs decoupled from substrate website
5274116
@nhussein11
fix: wip trransfer assets
1c6aa95
0xLucca
0xLucca previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben requested a review from a team as a code owner October 3, 2024 21:25
eshaben
eshaben previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben requested a review from 0xLucca October 3, 2024 21:46
0xLucca
0xLucca previously approved these changes Oct 3, 2024
View reviewed changes
@eshaben
Copy link
Collaborator

eshaben commented Oct 4, 2024

Good catches @DrW3RK! Thanks!

@nhussein11 nhussein11 dismissed stale reviews from 0xLucca and eshaben via f0b2f6d October 4, 2024 01:32
@nhussein11 nhussein11 requested a review from eshaben October 4, 2024 01:32
eshaben
eshaben reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a closer look and noticed a few more things. I think it should be good after this

develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
develop/parachain-devs/interoperability/transfer-assets-with-xcm.md Outdated Show resolved Hide resolved
@nhussein11
Copy link
Collaborator Author

nhussein11 commented Oct 4, 2024 •
edited
Loading

Took a closer look and noticed a few more things. I think it should be good after this

Thanks! Suggestions have been applied

I need approval from @DrW3RK to merge the PR since he requested changes, which have already been applied

@nhussein11 nhussein11 requested a review from DrW3RK October 4, 2024 02:14
@nhussein11 nhussein11 merged commit 31b082e into master Oct 4, 2024
@nhussein11 nhussein11 deleted the nhussein11/tutorials-substrate-transfer-assets-with-xcm branch October 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eshaben eshaben eshaben approved these changes

@DrW3RK DrW3RK DrW3RK approved these changes

@0xLucca 0xLucca 0xLucca left review comments

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09

Assignees
No one assigned
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nhussein11 @eshaben @dawnkelly09 @DrW3RK @0xLucca