Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polkadot Wiki Migration] Set up a Bootnode #34

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

infrastructure/general/setup-bootnode.md Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 20, 2024
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section's current structure lacks logical flow for developers. We could reorganize it and add more step-by-step guidance.

infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made most of the grammar type edits but there are a couple here as requested changes. @nhussein11 or @0xLucca please see comments about content needs. Thanks!


Before you start, you need to have the following prerequisites:

<!-- TODO: What goes here? -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xLucca or @nhussein11: please add the appropriate items here. We have a nice example in tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md on #29 so you can see what I mean. Thank you!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few, but please see if it needs to change.

infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested review from 0xLucca and eshaben October 2, 2024 20:17
@CrackTheCode016 CrackTheCode016 requested a review from a team as a code owner October 7, 2024 22:15
dawnkelly09
dawnkelly09 previously approved these changes Oct 8, 2024
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

infrastructure/general/.pages Show resolved Hide resolved
.snippets/code/infrastructure/general/bootnode.conf Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
infrastructure/general/setup-bootnode.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from formatting perspective

@eshaben eshaben requested a review from nhussein11 October 9, 2024 03:07
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhussein11 nhussein11 merged commit e14acb8 into master Oct 9, 2024
@nhussein11 nhussein11 deleted the bd-infra-setup-boot-node branch October 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants