Update entrypoint.sh to require mainnet RPC environment variables #34
Conversation
WalkthroughThe changes made to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant entrypoint.sh
participant RPC_Endpoints
User->>entrypoint.sh: Start script
entrypoint.sh->>entrypoint.sh: Check for Sepolia RPC variables
entrypoint.sh->>entrypoint.sh: Check for Mainnet RPC variables
entrypoint.sh->>RPC_Endpoints: Validate RPC endpoints
RPC_Endpoints-->>entrypoint.sh: Return validation result
entrypoint.sh->>User: Display error or proceed
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- entrypoint.sh (1 hunks)
Additional comments not posted (2)
entrypoint.sh (2)
7-9: Conditional checks for environment variables are correctly implemented.The expanded checks for both mainnet and sepolia network variables ensure that the script only proceeds if all required environment variables are set. This is crucial for the correct operation of the script in different network configurations.
Also applies to: 11-12
18-20: Command execution with new mainnet endpoints is correctly implemented.The inclusion of new mainnet endpoints in the command ensures that the script can operate with both mainnet and sepolia configurations. This broadens the usability of the script.
Consider verifying the correct operation of the
cached-eth-rpccommand with the new endpoints in a test environment to ensure everything functions as expected.
| exit 1 | ||
| fi | ||
|
|
||
| # Run the cached-eth-rpc command with environment variables | ||
| exec /app/cached-eth-rpc \ | ||
| --endpoint=eth-mainnet="$ETH_MAINNET_RPC" \ |
There was a problem hiding this comment.
i feel like we should somehow generate the endpoint parameters. This will load rpcs we don't need into different environments and doesn't allow us to easily set new endpoints
Summary by CodeRabbit
New Features
Bug Fixes