Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched metrics to used indexer data #98

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Switched metrics to used indexer data #98

merged 2 commits into from
Apr 26, 2024

Conversation

mvpoyatt
Copy link
Collaborator

@mvpoyatt mvpoyatt commented Apr 25, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new metrics fetching functionality, including details like chain ID, dispatcher address, transaction latency, and costs.
  • Refactor

    • Enhanced the GET function in metrics API for better data fetching and filtering based on query parameters.
    • Simplified the calcMetrics function for improved logic and error handling.
    • Removed unused function getLatestBlock and retained classNames for CSS class management.
  • Bug Fixes

    • Updated error logging to use a logger instance for better error management and tracking.

@mvpoyatt mvpoyatt requested review from Inkvi and dshiell April 25, 2024 21:29
Copy link

coderabbitai bot commented Apr 25, 2024

Walkthrough

The recent changes revolve around enhancing data fetching and metric calculations in various files within the codebase. These updates streamline packet data retrieval, improve error handling, and remove obsolete functions to boost performance and maintainability.

Changes

File Path Change Summary
app/api/metrics/helpers.ts Introduced functionality for fetching packet data, including chain ID, dispatcher address, transaction latency, and costs.
app/api/metrics/route.ts
app/metrics/route.ts
Refactored GET function to improve data fetching and filtering. Simplified response handling and switched from console.error to logger for error logging.
app/metrics/utils.ts Refactored calcMetrics to simplify logic, enhance error handling, update API call mechanism, and integrate logging using a logger instance.
app/utils/functions.tsx Removed getLatestBlock function while keeping classNames for CSS class name generation.

Poem

🐰✨
In the code's deep burrow, changes unfold,
Streamlined and sleek, making the codebase bold.
Packets swiftly fetched, errors in their lair,
Each line refined with utmost care.
Hopping through code, with joy we declare,
"Optimizing the burrow is our flair!" 🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d6d5afa and f5483a6.
Files selected for processing (1)
  • app/api/metrics/helpers.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/api/metrics/helpers.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mvpoyatt mvpoyatt marked this pull request as draft April 25, 2024 21:32
Copy link
Member

@dshiell dshiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 1 nit, otherwise lets get it tagged and test in staging

}

export async function getPackets(from?: number, to?: number): Promise<PacketData[]> {
from = from || Math.floor((Date.now() - 60 * 60 * 1000) / 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

now = Math.floor(Date.now() / 1000)
from = from || now - 60 * 60
to = to || now

@mvpoyatt mvpoyatt marked this pull request as ready for review April 26, 2024 01:02
@mvpoyatt mvpoyatt merged commit 9925a79 into main Apr 26, 2024
2 checks passed
@mvpoyatt mvpoyatt deleted the indexer-metrics branch April 26, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants