Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
joshklop committed Dec 19, 2024
1 parent 1790c7d commit 4a7dc1d
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions e2e/e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func Run(
"--monomer.sequencer",
))
// Use a headless dlv instance to debug the testapp.
// Connect using `dlv connect :2345`.
//nolint:gocritic // commentedOutCode
/*
appCmd := setupCmd(exec.CommandContext(ctx,
Expand Down
1 change: 0 additions & 1 deletion e2e/stack_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ func ethRollupFlow(t *testing.T, stack *e2e.StackConfig) {
// create a withdrawal tx to withdraw the deposited amount from L2 back to L1
withdrawalTx := e2e.NewWithdrawalTx(0, common.Address(userCosmosETHAddress), userETHAddress, withdrawalAmount, new(big.Int).SetUint64(params.TxGas))

t.Logf("FROM TEST: %s", userCosmosAddr)
baseAccount := queryAccount(t, stack, userCosmosAddr)
l2ChainID, err := stack.MonomerClient.ChainID(stack.Ctx)
require.NoError(t, err)
Expand Down
1 change: 0 additions & 1 deletion engine/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ func (e *EngineAPI) ForkchoiceUpdatedV1(
fcs eth.ForkchoiceState, //nolint:gocritic
pa *eth.PayloadAttributes,
) (*eth.ForkchoiceUpdatedResult, error) {
// TODO should this be called after Ecotone?
return e.ForkchoiceUpdatedV3(ctx, fcs, pa)
}

Expand Down
2 changes: 0 additions & 2 deletions opdevnet/opdevnet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ func TestOPDevnet(t *testing.T) {

l2SlotDuration := time.Duration(opConfig.Node.Rollup.BlockTime) * time.Second

t.Log("L1 and OP are setup")

// Confirm safe blocks are incrementing to ensure the batcher is posting blocks to the DA layer.
for l2Instance.Backend.BlockChain().CurrentSafeBlock().Number.Uint64() < 3 {
time.Sleep(l2SlotDuration)
Expand Down

0 comments on commit 4a7dc1d

Please sign in to comment.