ingress-controller/settings: remove cookie secure option (#872)

* ingress-controller/settings: remove cookie secure option

* fix newlines

apis/ingress/v1/pomerium_types.go

@@ -163,10 +163,6 @@ type Cookie struct {
 	// If you specify the domain explicitly, then subdomains would also be included.
 	// +optional
 	Domain *string `json:"domain,omitempty"`
-	// Secure if set to false, would make a cookie accessible over insecure protocols (HTTP).
-	// Defaults to <code>true</code>.
-	// +optional
-	Secure *bool `json:"secure,omitempty"`
 	// HTTPOnly if set to <code>false</code>, the cookie would be accessible from within the JavaScript.
 	// Defaults to <code>true</code>.
 	// +optional

config/crd/bases/ingress.pomerium.io_pomerium.yaml

@@ -122,10 +122,6 @@ spec:
                     - lax
                     - none
                     type: string
-                  secure:
-                    description: Secure if set to false, would make a cookie accessible
-                      over insecure protocols (HTTP). Defaults to <code>true</code>.
-                    type: boolean
                 type: object
               identityProvider:
                 description: IdentityProvider configure single-sign-on authentication

deployment.yaml

@@ -130,10 +130,6 @@ spec:
                     - lax
                     - none
                     type: string
-                  secure:
-                    description: Secure if set to false, would make a cookie accessible
-                      over insecure protocols (HTTP). Defaults to <code>true</code>.
-                    type: boolean
                 type: object
               identityProvider:
                 description: IdentityProvider configure single-sign-on authentication

pomerium/config.go

@@ -128,7 +128,6 @@ func applyCookie(_ context.Context, p *pb.Config, c *model.Config) error {
 	p.Settings.CookieDomain = c.Spec.Cookie.Domain
 	p.Settings.CookieName = c.Spec.Cookie.Name
 	p.Settings.CookieHttpOnly = c.Spec.Cookie.HTTPOnly
-	p.Settings.CookieSecure = c.Spec.Cookie.Secure
 	if c.Spec.Cookie.Expire != nil {
 		p.Settings.CookieExpire = durationpb.New(c.Spec.Cookie.Expire.Duration)
 	}

reference.md

@@ -167,7 +167,7 @@ PomeriumSpec defines Pomerium-specific configuration parameters.
                 </p>
                 <p>
 
-                    PassIdentityHeaders sets the <a href="https://www.pomerium.com/docs/reference/routes/pass-identity-headers">pass identity headers</a> option.
+                    PassIdentityHeaders sets the <a href="https://www.pomerium.com/docs/reference/pass-identity-headers">pass identity headers</a> option.
                 </p>
 
             </td>
@@ -423,22 +423,6 @@ Cookie defines Pomerium session cookie options.
             </td>
         </tr>
 
-        <tr>
-            <td>
-                <p>
-                <code>secure</code>&#160;&#160;
-
-                    <strong>boolean</strong>&#160;
-
-                </p>
-                <p>
-
-                    Secure if set to false, would make a cookie accessible over insecure protocols (HTTP). Defaults to <code>true</code>.
-                </p>
-
-            </td>
-        </tr>
-
     </tbody>
 </table>