Skip to content

Commit

Permalink
Makefile: unset GOOS for get-envoy command (#1088)
Browse files Browse the repository at this point in the history
Ingress Controller can be built on macOS by running a command like

  GOOS=linux make build && docker build . -t ingress-controller:dev

except that this will attempt to build and run the get-envoy command for
Linux as well, which won't work. Let's update the Makefile 'envoy'
target to unset the GOOS variable so that the get-envoy command is
always built for the host OS.
  • Loading branch information
kenjenkins authored Jan 17, 2025
1 parent df4b1a8 commit da10b08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ envoy-ci: envoy
.PHONY: envoy
envoy:
@echo "==> $@"
mkdir -p ./pomerium/envoy/bin && cd ./pomerium/envoy/bin && go run github.com/pomerium/pomerium/pkg/envoy/get-envoy
mkdir -p ./pomerium/envoy/bin && cd ./pomerium/envoy/bin && env -u GOOS go run github.com/pomerium/pomerium/pkg/envoy/get-envoy

UI_DIR = $(shell go list -f {{.Dir}} github.com/pomerium/pomerium/ui)
internal/ui:
Expand Down

0 comments on commit da10b08

Please sign in to comment.