Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: add codec_type #1085

Merged
merged 2 commits into from
Jan 8, 2025
Merged

settings: add codec_type #1085

merged 2 commits into from
Jan 8, 2025

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Jan 7, 2025 •
edited
Loading

Summary

Add the codec_type setting.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Jan 7, 2025
@calebdoxsey
Copy link
Contributor Author

This also changes the default ports so we bind :443 and :80 instead of :8443 and :8080.

@calebdoxsey calebdoxsey marked this pull request as ready for review January 7, 2025 22:50
@calebdoxsey calebdoxsey requested a review from a team as a code owner January 7, 2025 22:50
@calebdoxsey calebdoxsey requested review from kralicky and removed request for a team January 7, 2025 22:50
@calebdoxsey calebdoxsey merged commit fef68c1 into main Jan 8, 2025
7 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/eng-1788-expose-codec_type-in-ingress-controller branch January 8, 2025 23:14
@wasaga
Copy link
Collaborator

wasaga commented Jan 13, 2025

related: https://linear.app/pomerium/issue/ENG-1865/installingress-controller-update-ports-in-terraform

@kenjenkins kenjenkins mentioned this pull request Jan 14, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kralicky kralicky kralicky approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebdoxsey @wasaga @kralicky