[RFC] Add support for static linking of libressl #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
SeanTAllen
reviewed
Dec 10, 2024
Comment on lines
32
to
42
| INPUT_LIBRARY_NAME: "net_ssl" | ||
| INPUT_DOCS_BUILD_DIR: "build/net_ssl-docs" | ||
| - name: Setup Pages | ||
| uses: actions/configure-pages@v2 | ||
| uses: actions/configure-pages@v5 | ||
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v1 | ||
| with: | ||
| path: 'build/net_ssl-docs/site/' | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v1 | ||
| uses: actions/deploy-pages@v4 |
There was a problem hiding this comment.
This is unrelated, please move to a different PR
|
What's the use case here? |
|
Also, does this work on macOS? |
SeanTAllen
reviewed
Dec 10, 2024
.github/workflows/release.yml
Outdated
Comment on lines
55
to
67
| INPUT_DOCS_BUILD_DIR: "build/net_ssl-docs" | ||
| - name: Setup Pages | ||
| uses: actions/configure-pages@v2 | ||
| uses: actions/configure-pages@v5 | ||
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v1 | ||
| with: | ||
| path: 'build/net_ssl-docs/site/' | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v1 | ||
| uses: actions/deploy-pages@v4 | ||
|
|
||
| trigger-release-announcement: | ||
| name: Trigger release announcement |
There was a problem hiding this comment.
FYI both of those updates are breaking changes. Can you back them out and I will handle that update.
|
What's the [RFC] in the title indicate? |
As it was written above: "It is presented as a Proof of concept and request for comments." |
I don't have a macOS system at hand, so I cannot test this. This likely needs some tweeks to work there. Or it doesn't. |
mfelsche
force-pushed
the
link-static
branch
from
07a9f80 to
26602de
Compare
SeanTAllen
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental change that enables the
net_sslpackage to not depend upon the system openssl variant, but can be compiled with a pinned vendored libressl version. It is presented as a Proof of concept and request for comments.This feature could be made available by pony applications using this library by enabling a feature switch
-Dlink_static. The naming of this flag is also just experimental and should have a prefix likenet_ssl, so it won't collide with other libraries (e.g.crypto).Windows support is also missing. I don't even know if this is even possible on windows.