Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "how to install on Linux" instructions #3598

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Update "how to install on Linux" instructions #3598

merged 1 commit into from
Sep 8, 2020

Conversation

SeanTAllen
Copy link
Member

@Theodus can you help me complete writing this, possibly adding needed ponyup issues and features as we go?

@SeanTAllen SeanTAllen requested a review from Theodus July 21, 2020 00:51
@SeanTAllen
Copy link
Member Author

Something I intend to add is how to request a new distro and the criteria.

@SeanTAllen SeanTAllen marked this pull request as draft July 21, 2020 00:52
@SeanTAllen SeanTAllen mentioned this pull request Jul 21, 2020
Closed
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Aug 29, 2020
@ponylang ponylang deleted a comment from ponylang-main Aug 29, 2020
@SeanTAllen SeanTAllen removed the changelog - added Automatically add "Added" CHANGELOG entry on merge label Aug 29, 2020
Theodus
Theodus reviewed Aug 30, 2020
View reviewed changes
INSTALL.md Outdated

If you get an error like: `ponyc: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ponyc)` then your version of Glibc is not compatible.

You can use `ponyup show ponyc` to see all available distributions. Select the one that matches your distro using the `ponyup default` command. For example:
Copy link
Contributor

@Theodus Theodus Aug 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ponyup show command only lists installed packages right now. We should either wait for find to be implemented, or direct people to https://cloudsmith.io/~ponylang/repos/releases/packages/?q=x86-64+linux to look for available distributions

@SeanTAllen
Copy link
Member Author

@Theodus I figured out what I am going to do for this for now.

Going to advise everyone to run

ponyup default FOO after installing on a glibc Linux where we have a table listing their distro and the FOO to put. If they don't see theirs listed, give ponyc a try. If it doesn't work and their distro is a current long term support release version then they can open an issue requesting prebuilt binaries.

Sound good?

@SeanTAllen SeanTAllen changed the title WIP Update "how to install on Linux" instructions Sep 5, 2020
@SeanTAllen
Copy link
Member Author

@Theodus can you give this another review?

@SeanTAllen
Update "how to install on Linux" instructions
61b68df 
Glibc makes the story a little complicated. Hopefully, this helps
clear things up for folks.

Closes #3600
@SeanTAllen SeanTAllen marked this pull request as ready for review September 5, 2020 23:25
@SeanTAllen SeanTAllen requested a review from a team September 8, 2020 14:32
@Theodus
Copy link
Contributor

Theodus commented Sep 8, 2020

We should also have a section for the FreeBSD 12.1 prebuilt image.

Theodus
Theodus approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions

INSTALL.md
@@ -14,20 +14,50 @@ Starting with the next ponyc release, you'll also be able to download prebuilt p

Prebuilt Linux packages are available via [ponyup](https://github.com/ponylang/ponyup) for Glibc and musl libc based Linux distribution. You can install nightly builds as well as official releases using ponyup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify that we only have prebuilt images for AMD64 at this time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a suggest a change for that and I'll incorporate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually that feels like a different PR, agreed? As it applies in general across all platforms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're correct, since macOS and Windows will likely have more widespread ARM support soon.

@SeanTAllen
Copy link
Member Author

@Theodus I added issues based on your notes.

@SeanTAllen SeanTAllen merged commit 9d976fe into master Sep 8, 2020
@SeanTAllen SeanTAllen deleted the supported branch September 8, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theodus Theodus Theodus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanTAllen @Theodus