Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google benchmark dependency #4577

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update google benchmark dependency #4577

merged 1 commit into from
Jan 7, 2025

Conversation

dspx-plcr
Copy link
Contributor

Google benchmark 1.8.4 includes this change, which is required to build the pony libs on OpenBSD.

Bumping the dependency to the latest release.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 4, 2025
@SeanTAllen SeanTAllen requested a review from chalcolith January 4, 2025 22:08
@SeanTAllen
Copy link
Member

SeanTAllen commented Jan 4, 2025 •
edited
Loading

@chalcolith does our CI test at this time that we can compile new versions of gbenchmark?
From my examination of the logs, I believe it is. I just want to verify with you as I feel like we discussed not doing that at some point but I can find no evidence we actually did.

SeanTAllen
SeanTAllen approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@SeanTAllen SeanTAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. But I want an approval from Gordon as well.

@SeanTAllen
Copy link
Member

Thanks @dspx-plcr.

@SeanTAllen
Copy link
Member

Discussed with @chalcolith. All good. Thanks again @dspx-plcr.

@SeanTAllen SeanTAllen merged commit 9b1e66d into ponylang:main Jan 7, 2025
24 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen approved these changes

@chalcolith chalcolith chalcolith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dspx-plcr @SeanTAllen @chalcolith @ponylang-main