Fix unaligned read in fun.c siphash #4603
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
SeanTAllen
changed the title
|
the can someone poke at it to run again? |
|
@dipinhora rebase against main. that will cause a new run and it will pick up your cycle detector test change. |
dipinhora
force-pushed
the
happyubsan_unaligned_read
branch
from
aa98996 to
7734a55
Compare
but i was being lazy.. 8*/ . . . . . done.. |
dipinhora
force-pushed
the
happyubsan_unaligned_read
branch
from
7734a55 to
116a7cd
Compare
ubsan doesn't like it when unaligned reads happen. this commit fixes things to make ubsan happy. NOTE: fix uses `memcpy` which at least some compilers optimize well. See: https://blog.quarkslab.com/unaligned-accesses-in-cc-what-why-and-solutions-to-do-it-properly.html Makes ubsan runtime errors such as the following go away: `runtime error: load of misaligned address 0xb2af29174143 for type 'uint64_t' (aka 'unsigned long'), which requires 8 byte alignment`
dipinhora
force-pushed
the
happyubsan_unaligned_read
branch
from
116a7cd to
fc768c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubsan doesn't like it when unaligned reads happen. this commit fixes things to make ubsan happy.
NOTE: fix uses
memcpywhich at least some compilers optimize well.See: https://blog.quarkslab.com/unaligned-accesses-in-cc-what-why-and-solutions-to-do-it-properly.html
Makes ubsan runtime errors such as the following go away:
runtime error: load of misaligned address 0xb2af29174143 for type 'uint64_t' (aka 'unsigned long'), which requires 8 byte alignment