Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select uses latest version if none is specified #139

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Select uses latest version if none is specified #139

merged 2 commits into from
Aug 12, 2020

Conversation

Theodus
Copy link
Contributor

@Theodus Theodus commented Aug 12, 2020

Closes #85

@Theodus Theodus added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Aug 12, 2020
@Theodus Theodus requested a review from SeanTAllen August 12, 2020 19:23
SeanTAllen
SeanTAllen approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@SeanTAllen SeanTAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good test we could add for this so it doesn't get broken in the future and we can feel more confident in accepting PRs from other folks?

@SeanTAllen
Copy link
Member

Can you manually add release notes to "next-release.md" as I haven't completed all the work on that yet?

@SeanTAllen
Copy link
Member

@Theodus with #140 merged, you can add a "regular release notes" file like "139.md" rather than modifying "next-release.md" directly and we can verify that works.

@Theodus Theodus requested a review from SeanTAllen August 12, 2020 19:51
@SeanTAllen
Copy link
Member

Release notes look good @Theodus. Any thoughts on test(s)?

@Theodus
Copy link
Contributor Author

Theodus commented Aug 12, 2020

The select command is currently tested through the automatic select that happens on update, so there isn't an easy way to add a test for this feature. Note for #48

@Theodus Theodus merged commit 956a756 into master Aug 12, 2020
@Theodus Theodus deleted the select-latest branch August 12, 2020 20:02
github-actions bot pushed a commit that referenced this pull request Aug 12, 2020
@ponylang-main
Update CHANGELOG for PR #139 [skip ci]
e9978b4
@Theodus
Copy link
Contributor Author

Theodus commented Aug 12, 2020

@SeanTAllen I don't think the release notes bot worked

@SeanTAllen
Copy link
Member

@Theodus yup. im a dumbass. can you...

  1. remove your file and manually update next-release.md
  2. rename .release_notes to .release-notes

thanks.

@Theodus
Copy link
Contributor Author

Theodus commented Aug 12, 2020

fixed: f67d4fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen Awaiting requested review from SeanTAllen

Assignees
No one assigned
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select fails on latest version
2 participants
@Theodus @SeanTAllen