Migrate away from Rectangle::from_loc_and_size
#1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
from-loc-and-size
branch
2 times, most recently
from
3f5b818 to
f28371a
Compare
|
Updating Smithay now that Smithay/smithay#1621 is merged I see a bunch of build errors related to Smithay/smithay#1576, so I guess I'll update this after #1020 is merged. |
Deprecated in `smithay` by Smithay/smithay#1621.
ids1024
force-pushed
the
from-loc-and-size
branch
from
f28371a to
801ed5a
Compare
ids1024
changed the title
Rectangle::from_loc_and_sizeRectangle::from_loc_and_size
Drakulix
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Smithay/smithay#1621.
Annoying to update, but overall a little bit better.
Some of these
Rectangle::newcalls should probably be written in a way that doesn't construct newPoint/Sizeinstances from scalars and uses higher-level operations that preserve coordinate space, but this doesn't change that for now. (If we can move Smithay toeuclidthat should have a few more useful methods to clean up things like that too.)