Improve window positioning when toggling tiling on #1125
+203
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! This is a quality of life change I've been working on. I frequently switch back and forth between using tiling and floating windows, and thought it would be nice to be able to position windows in floating mode and preserve those positions when turning on tiling.
This change updates the tiling layout code to attempt to preserve relative window positioning and sizes as much as possible when turning on toggling.
At a high level, the algorithm for this is to iteratively:
Mapped
leaf into the tree, otherwise create aGroup
and placeholders for the windows to be solved.Here's a small demo video: Demo
This is the first time I've written a significant amount of Rust, so any feedback on anything non-idiomatic would be appreciated. Cheers!