feat: enable limiting applications to a single instance #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll make a PR with dbus-activation instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could allow applications to only allow a single instance by default, and when another instance is started, the arguments are passed to the existing application. I could see this possibly being useful for the applets that need to open a specific page of settings. They could spawn
cosmic-settings --networkfor example, which might open a new instance on the network configuration page, or if there is one running, the arguments would be passed to the existing instance via dbus. Maybe we should make the interface match d-bus activation? This implementation is a bit different from GApplication and doesn't really use d-bus activation.