Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: TableView widget #768

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

[WIP] feat: TableView widget #768

wants to merge 22 commits into from
+1,598 −1

Conversation

Adam-Cosner
Copy link
Contributor

@Adam-Cosner Adam-Cosner commented Dec 30, 2024 •
edited
Loading

Currently fully meets the base design standard, the following features are to be implemented in the future as needed:

  • Context menus
    • Item context menu
    • Category context menu
  • Drag n Drop
  • Keyboard control
    • User-defined keyboard actions
  • Custom widget instead of deferring to other widgets
    • in-widget control of compact and standard view switching

mmstick
mmstick reviewed Jan 3, 2025
View reviewed changes
src/widget/table/model/mod.rs
@@ -0,0 +1,360 @@
pub mod category;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of duplicated code here with the segmented button model. Perhaps we should make something more generic that is shared between them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some code we could theoretically merge but they ultimately still need to be separate as they are fundamentally storing different data

@Adam-Cosner Adam-Cosner marked this pull request as draft January 4, 2025 20:04
@Adam-Cosner Adam-Cosner changed the title Add rudimentary TableView widget [WIP] feat: TableView widget Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmstick mmstick mmstick left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adam-Cosner @mmstick