Update Handling For When Linking New External Credentials Without IdP email and Refactor def openid_connect
#1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronskiba
commented
Jan 21, 2025
| attrs: auth, | ||
| identifiable: current_user) | ||
| flash[:notice] = _('Linked successfully') | ||
| redirect_to root_path |
There was a problem hiding this comment.
Should I change this too? Currently, after linking an account within Edit Profile, the user is then redirected to the root path. Would it be better to just keep them on the Edit Profile page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966
Changes proposed in this PR:
Updates handling for when
if auth.info.email.nil? && user.nil?Previously, when this condition was true, the following code was executed:
Now, the executed code is contingent on whether or not the user is signed into the app (see
def handle_missing_email_for_new_sso_entry).In addition, this pull request addresses the outstanding
Metrics/AbcSizeandMetrics/MethodLengthrubocop offenses that existed withindef openid_connect.