Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE Rx parsing improvements #1566

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

iNetro
Copy link
Contributor

@iNetro iNetro commented Nov 7, 2023

No description provided.

Fixed buffer size 2048 was too large for a decimated before only containing 512 (2048/4 Decimation) Bytes.
@NotherNgineer
Copy link
Contributor

Just FYI -- I just wanted to point out that when the next official firmware Release is built, the release notes will just list the title lines from each PR. Because of that, it might be helpful if the PR title line mentioned BLE so it would be more clear (to other users) what this PR pertains to...

@iNetro
Copy link
Contributor Author

iNetro commented Nov 7, 2023

Just FYI -- I just wanted to point out that when the next official firmware Release is built, the release notes will just list the title lines from each PR. Because of that, it might be helpful if the PR title line mentioned BLE so it would be more clear (to other users) what this PR pertains to...

You're right, I wasn't thinking clearly what I made that title lol.. I'll fix it.

@iNetro iNetro changed the title Rx parsing improvements BLE Rx parsing improvements Nov 7, 2023
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, let's see if it's an improvement now !

@gullradriel gullradriel merged commit a9df9dd into portapack-mayhem:next Nov 7, 2023
@iNetro iNetro deleted the rx_parsing_improvements branch November 8, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants