-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new app "hopper" app. #2482
Open
zxkmm
wants to merge
12
commits into
portapack-mayhem:next
Choose a base branch
from
zxkmm:hopper_app
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @zxkmm , still a draft ? |
Ya sorry gull, the new path declaration extends the inner space and I need to move an app to external before this merged XD |
Yeah, we're short on firmware space. |
I fixed the conflicts. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are one thing to discuss:
jammer app is a bit weird designed, that they claimed a ram region like this:
Which sort of looks like a thing that communication between m0 and m4. I don't know how it use the ram but it looks like it will always in ram. and if we wanna keep both app, the only way would be i claim another region something like this:
AI summary
This pull request introduces a new external application called "Hopper" to the firmware. The changes include updates to multiple files to integrate this new application, including adding the necessary source files, memory allocation, and UI components.
Integration of Hopper application:
firmware/application/external/external.cmake
: Addedhopper
source files toEXTCPPSRC
andhopper
toEXTAPPLIST
. [1] [2]firmware/application/external/external.ld
: Allocated memory for thehopper
application and added sections for it. [1] [2]New source files for Hopper:
firmware/application/external/hopper/main.cpp
: Added the main implementation file for thehopper
application, including initialization and application information.firmware/application/external/hopper/ui_hopper.cpp
: Added the UI implementation for thehopper
application, including frequency management and transmission control.firmware/application/external/hopper/ui_hopper.hpp
: Added the header file for thehopper
UI, defining theHopperView
class and its methods.File path updates:
firmware/application/file_path.cpp
: Addedhopper_dir
path for storing Hopper-related files.firmware/application/file_path.hpp
: Declared thehopper_dir
path.Shared memory and navigation updates:
firmware/common/portapack_shared_memory.hpp
: AddedHopperChannel
struct and updated shared memory to includehopper_channels
. [1] [2]firmware/application/ui_navigation.cpp
: Commented out thesubghzd
entry in the app list.