Update dependencies #1401
clippy
16 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 16 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 465 in src/web.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> src/web.rs:459:15
|
459 | let csp = vec![
| _______________^
460 | | "sandbox allow-scripts allow-forms",
461 | | "default-src 'none'",
462 | | "script-src 'self'",
463 | | "style-src 'self'",
464 | | "form-action *",
465 | | ]
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
459 ~ let csp = ["sandbox allow-scripts allow-forms",
460 + "default-src 'none'",
461 + "script-src 'self'",
462 + "style-src 'self'",
463 + "form-action *"]
|
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:93:61
|
93 | pub static ref DOMAIN_VALIDATION_ERROR: IntCounterVec = register_int_counter_vec!(
| _____________________________________________________________^
94 | | "portier_domain_validation_error",
95 | | "Number of authentication requests for invalid domains",
96 | | &["reason"]
97 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `__register_counter_vec` which comes from the expansion of the macro `register_int_counter_vec` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:88:54
|
88 | pub static ref AUTH_OIDC_COMPLETED: IntCounter = register_int_counter!(
| ______________________________________________________^
89 | | "portier_auth_oidc_completed",
90 | | "Number of successful OpenID Connect authentications"
91 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:83:63
|
83 | pub static ref AUTH_OIDC_FETCH_JWKS_DURATION: Histogram = register_histogram!(
| _______________________________________________________________^
84 | | "portier_auth_oidc_fetch_jwks_duration",
85 | | "Latency of outgoing requests for OpenID Connect JWKs"
86 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_histogram` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:78:65
|
78 | pub static ref AUTH_OIDC_FETCH_CONFIG_DURATION: Histogram = register_histogram!(
| _________________________________________________________________^
79 | | "portier_auth_oidc_fetch_config_duration",
80 | | "Latency of outgoing requests for OpenID Connect configuration documents"
81 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_histogram` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:68:56
|
68 | pub static ref AUTH_OIDC_REQUESTS: IntCounterVec = register_int_counter_vec!(
| ________________________________________________________^
69 | | "portier_auth_oidc_requests",
70 | | "Number of authentication requests that used OpenID Connect",
71 | | &["rel"]
72 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `__register_counter_vec` which comes from the expansion of the macro `register_int_counter_vec` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:63:60
|
63 | pub static ref AUTH_EMAIL_CODE_INCORRECT: IntCounter = register_int_counter!(
| ____________________________________________________________^
64 | | "portier_auth_email_code_incorrect",
65 | | "Number of email confirmation attempts with an invalid code"
66 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:58:55
|
58 | pub static ref AUTH_EMAIL_COMPLETED: IntCounter = register_int_counter!(
| _______________________________________________________^
59 | | "portier_auth_email_completed",
60 | | "Number of successful email authentications"
61 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:53:58
|
53 | pub static ref AUTH_EMAIL_SEND_DURATION: Histogram = register_histogram!(
| __________________________________________________________^
54 | | "portier_auth_email_send_duration",
55 | | "Latency of sending email"
56 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_histogram` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:48:54
|
48 | pub static ref AUTH_EMAIL_REQUESTS: IntCounter = register_int_counter!(
| ______________________________________________________^
49 | | "portier_auth_email_requests",
50 | | "Number of authentication requests that used email"
51 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:43:57
|
43 | pub static ref AUTH_WEBFINGER_DURATION: Histogram = register_histogram!(
| _________________________________________________________^
44 | | "portier_auth_webfinger_duration",
45 | | "Latency of outgoing Webfinger requests."
46 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_histogram` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:38:48
|
38 | pub static ref AUTH_REQUESTS: IntCounter = register_int_counter!(
| ________________________________________________^
39 | | "portier_auth_requests",
40 | | "Number of authentication requests"
41 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:33:47
|
33 | pub static ref AUTH_LIMITED: IntCounter = register_int_counter!(
| _______________________________________________^
34 | | "portier_auth_limited",
35 | | "Number of rate-limited authentication requests"
36 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:17:58
|
17 | pub static ref HTTP_RESPONSE_STATUS: IntCounterVec = register_int_counter_vec!(
| __________________________________________________________^
18 | | "portier_http_response_status",
19 | | "Number of HTTP responses by status category",
20 | | &["code"]
21 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `__register_counter_vec` which comes from the expansion of the macro `register_int_counter_vec` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:12:48
|
12 | pub static ref HTTP_REQUESTS: IntCounter = register_int_counter!(
| ________________________________________________^
13 | | "portier_http_requests",
14 | | "Number of HTTP requests processed"
15 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
matching over `()` is more explicit
warning: matching over `()` is more explicit
--> src/metrics.rs:7:51
|
7 | pub static ref HTTP_CONNECTIONS: IntCounter = register_int_counter!(
| ___________________________________________________^
8 | | "portier_http_connections",
9 | | "Number of HTTP connections accepted"
10 | | ).unwrap();
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
note: the lint level is defined here
--> src/main.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::ignored_unit_patterns)]` implied by `#[warn(clippy::pedantic)]`
= note: this warning originates in the macro `register_counter` which comes from the expansion of the macro `register_int_counter` (in Nightly builds, run with -Z macro-backtrace for more info)