Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session tab list view to console pane #6160

Open
8 of 12 tasks
dhruvisompura opened this issue Jan 30, 2025 · 0 comments
Open
8 of 12 tasks

Add session tab list view to console pane #6160

dhruvisompura opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request

Comments

@dhruvisompura
Copy link
Contributor

dhruvisompura commented Jan 30, 2025

Create a tab list component that displays active sessions in the order they are created. The tab list does not need to support drag and drop reordering in this pass.

Each tab will display the following information in order:

  • session state (idle/busy/shutdown)
  • language icon
  • session name
    • Will require a global counter tacked on the end of the session name to differentiate between duplicate sessions

To change the active session, a user can click on a tab from the console tab list. The console tab list will use the tab pattern documented here: https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/

Testing:

  • Verify shutdown behavior for the active session
    • Verify the status indicator shows disconnected
  • Verify shutdown behavior for more than one active console session
    • Ensure the status indicator for the correct session changes
  • Verify the tab list is accessible (aria attributes, focus state, and keyboard navigation)
  • Verify that active session changes for editor, and variables panes
    • Verify variables pane switches context to new active session and displays the variables for the new active session
  • Verify changing variables pane session does not change primary active session for console/editor.
    • Note: This behavior has had a regression and can be skipped for testing until fixed.
  • Verify there is an output channel for the session
  • Verify the status indicator shows busy when code is executing for a session
  • Verify the status indicator shows idle
@dhruvisompura dhruvisompura added enhancement New feature or request area: console Issues related to Console category. and removed enhancement New feature or request labels Jan 30, 2025
@dhruvisompura dhruvisompura added this to the 2025.03 Pre-Release milestone Jan 30, 2025
@dhruvisompura dhruvisompura self-assigned this Jan 30, 2025
@dhruvisompura dhruvisompura added enhancement New feature or request area: ui Issues related to UI category. labels Feb 1, 2025
dhruvisompura added a commit that referenced this issue Feb 19, 2025
### Description 
Addresses #6160

This change introduces the new console tab list view in the console pane
behind the `positron.mulitpleConsoleSessions` feature flag. The console
tab list follows the tab list pattern for accessibility:
https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/

This issue does not address #6199 which is related since the console tab
list can be resized. The console tab list resizing behavior can
definitely use some improvement but can be tackled as polish.

### Release Notes

#### New Features

- N/A

#### Bug Fixes

- N/A


### QA Notes

Please see testing notes under #6160

### Screenshots

**Resize Console Pane**


https://github.com/user-attachments/assets/3467f38e-4f54-4f65-b27f-ab0601117d1e

**Switch Sessions**


https://github.com/user-attachments/assets/70d1510f-4b91-45f7-a399-d3b146f49cd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant