Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes variable grouping #2088

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add classes variable grouping #2088

merged 2 commits into from
Jan 25, 2024

Conversation

jgutman
Copy link
Contributor

@jgutman jgutman commented Jan 19, 2024

there are a bunch of changes #1788 (comment) we discussed to the variable pane and its groupings, several of which probably require some discussion/alignment. One of the more straightforward ones is breaking off Classes as a distinct group from the catch-all Values. If I import a class from a module or submodule, or if I create my own class in the console, it will be grouped under Values, but this doesn't feel quite right. So along with the accompanying PR on the Python extension, adding a new category called Classes. (This could in theory be used in the R extension as well, but because of how R imports work, R classes won't show up in the Variables pane the way Python classes currently do, so probably less necessary. We will still need to commit the auto-generated changes to crates/amalthea/src/comm/variables_comm.rs though)

@jgutman jgutman requested review from ajmcoqui, isabelizimm and petetronic and removed request for ajmcoqui January 19, 2024 17:34
@jgutman jgutman merged commit 2fbc72d into main Jan 25, 2024
1 check passed
@wesm wesm deleted the add_classes_variable_grouping branch March 15, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant