Use "positron" as the publisher for our extensions #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Dec 4, 2024
| @@ -114,7 +114,7 @@ suite('Python Runtime Session', () => { | |||
| } as Partial<JupyterAdapterApi>) as JupyterAdapterApi; | |||
|
|
|||
| sinon.stub(vscode.extensions, 'getExtension').callsFake((extensionId) => { | |||
| if (extensionId === 'vscode.kallichore-adapter' || extensionId === 'vscode.jupyter-adapter') { | |||
There was a problem hiding this comment.
@jmcphers was this maybe an oversight that this still said vscode.kallichore-adapter? I want to highlight that I have changed it here to positron.positron-adapter.
There was a problem hiding this comment.
It's an oversight, but should be positron.positron-supervisor.
jmcphers
previously approved these changes
Dec 4, 2024
| @@ -114,7 +114,7 @@ suite('Python Runtime Session', () => { | |||
| } as Partial<JupyterAdapterApi>) as JupyterAdapterApi; | |||
|
|
|||
| sinon.stub(vscode.extensions, 'getExtension').callsFake((extensionId) => { | |||
| if (extensionId === 'vscode.kallichore-adapter' || extensionId === 'vscode.jupyter-adapter') { | |||
There was a problem hiding this comment.
It's an oversight, but should be positron.positron-supervisor.
extensions/positron-python/src/test/positron/session.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan <[email protected]> Signed-off-by: Julia Silge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5268
After experimenting with this, I believe we should only update the publisher on extensions that we ourselves truly did make, not ones that we forked and made changes to. As an example, the Black formatter (which we bundle) depends on the
ms-python.pythonextension ID; if we change our Python extension to bepositron.pythonthen we can no longer bundle the Black formatter.QA Notes
Most importantly, there should be no errors as the app comes up about extensions being activated, and both R and Python runtimes should start.
There are more implications for changing this publisher in the long term as outlined in #5268, but to confirm we have successfully updated it, you can look for some of the builtin extensions in the Extensions tab and see that they say they have the "positron" publisher: