Fix inconsistency when concurrently starting a session and session.start() rejects
#5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
requested changes
Dec 6, 2024
seeM
force-pushed
the
fix-inconsistency-when-session-start-rejects
branch
from
444cabe to
7babed8
Compare
|
@jmcphers I've made the change. Running the full test suite just in case throwing the error causes any unexpected issues: https://github.com/posit-dev/positron/actions/runs/12235628385 (EDIT: It passed) |
jmcphers
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2671.
I didn't encounter this in practice but noticed the inconsistency while working with the code.
I assume it is intended for the outer call to not reject when
session.start()rejects, so concurrent calls probably also shouldn't reject.