Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: add pop out tests for plots to editor #5634

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

testlabauto
Copy link
Contributor

@testlabauto testlabauto commented Dec 5, 2024

Just adding popout of plots to editor testing into existing plots tests suite.

Also, added code to clear clipboard after copying to it so tests do not interfere with each other.

Note that unit and integration time out problems fixed separately.

QA Notes

All smoke tests should pass.

Copy link
Contributor

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should closeAllEditors be in the an afterEach hook?

@testlabauto
Copy link
Contributor Author

Should closeAllEditors be in the an afterEach hook?

well, only 3 cases out of 17 use it, so I was hesitant to add it there.

@testlabauto testlabauto merged commit 76077c8 into main Dec 5, 2024
3 of 5 checks passed
@testlabauto testlabauto deleted the cmead/plots-pop-out-test branch December 5, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants