Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show content emitted by kernel supervisor when it fails to connect #5983

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jmcphers
Copy link
Collaborator

This change is intended to help troubleshoot #5337, which continues to show up occasionally in CI but for which no one has found a reliable local repro.

It shows any output emitted by the supervisor alongside the connection timeout message, for easy debugging.

@jmcphers jmcphers requested a review from midleman January 14, 2025 03:01
Copy link

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

// user can see it without clicking over to the logs.
if (fs.existsSync(outFile)) {
// Note that we don't need to append this content
// to the lgos since the output file is already
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, lgos -> logs

Copy link
Contributor

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jmcphers jmcphers merged commit adf5792 into main Jan 22, 2025
8 checks passed
@jmcphers jmcphers deleted the feature/kallichore-connect-timeout-logs branch January 22, 2025 00:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants