-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Data Explorer action bar actions to Editor Actions and the Editor Action Bar #6000
Move Data Explorer action bar actions to Editor Actions and the Editor Action Bar #6000
Conversation
E2E Tests 🚀 |
@softwarenerd recommend running Data Explorer tests tag too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great! The new way "Clear Column Sorting" works is super nice, and I really like having some of the Data Explorer actions in a little menu. 🤩
For #5360, I see that when I use a gesture to turn on the editor action bar (via the menu or the setting) that the other ones toggle off. ✅
I agree that we should run the Data Explorer tests here, to see if anything needs to be updated. 👍
@softwarenerd recommend running Data Explorer tests tag too? Yep. I thought I had done this. It's set to run them now. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! 🙌
Description
This PR moves the Data Explorer action bar into Editor Actions and the Editor Action Bar (depending on configuration, below).
Tests:
@:editor-action-bar
@:data-explorer
Release Notes
New Features
The Editor Action Bar can now be configured to be visible via the View -> Appearance -> Action Bar menu item:
As well as through settings:
Bug Fixes
#5360
#5361
QA Notes
When you enable the Editor Action Bar, the Editor Actions Position will automatically be configured to be Hidden. When you disable the Editor Action Bar, the Editor Actions Position will automatically be configured to be Tab Bar.
For testing purposes, you can reconfigure the Editor Actions Position to be Tab Bar or Title Bar so that both the Editor Action Bar and Editor Actions are shown. This is a temporary capability so that testers can verify the Editor Action Bar.