Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Data Explorer action bar actions to Editor Actions and the Editor Action Bar #6000

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Jan 15, 2025

Description

This PR moves the Data Explorer action bar into Editor Actions and the Editor Action Bar (depending on configuration, below).

Tests:
@:editor-action-bar
@:data-explorer

Release Notes

New Features

The Editor Action Bar can now be configured to be visible via the View -> Appearance -> Action Bar menu item:

image

As well as through settings:

image

Bug Fixes

#5360
#5361

QA Notes

When you enable the Editor Action Bar, the Editor Actions Position will automatically be configured to be Hidden. When you disable the Editor Action Bar, the Editor Actions Position will automatically be configured to be Tab Bar.

For testing purposes, you can reconfigure the Editor Actions Position to be Tab Bar or Title Bar so that both the Editor Action Bar and Editor Actions are shown. This is a temporary capability so that testers can verify the Editor Action Bar.

Copy link

github-actions bot commented Jan 15, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:editor-action-bar @:data-explorer

readme  valid tags

@softwarenerd softwarenerd marked this pull request as ready for review January 15, 2025 02:21
@petetronic
Copy link
Collaborator

@softwarenerd recommend running Data Explorer tests tag too?

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great! The new way "Clear Column Sorting" works is super nice, and I really like having some of the Data Explorer actions in a little menu. 🤩

For #5360, I see that when I use a gesture to turn on the editor action bar (via the menu or the setting) that the other ones toggle off. ✅

I agree that we should run the Data Explorer tests here, to see if anything needs to be updated. 👍

@softwarenerd softwarenerd changed the title Feature/use editor action bar for data explorer Move Data Explorer action bar actions to the Editor Action Bar Jan 15, 2025
@softwarenerd softwarenerd changed the title Move Data Explorer action bar actions to the Editor Action Bar Move Data Explorer action bar actions to Editor Actions and the Editor Action Bar Jan 15, 2025
@softwarenerd
Copy link
Contributor Author

softwarenerd commented Jan 15, 2025

@softwarenerd recommend running Data Explorer tests tag too?

Yep. I thought I had done this. It's set to run them now. The Data Explorer - Python Polars test was failing, so I worked to fix this with @midleman this morning.

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@softwarenerd softwarenerd merged commit ebd0e02 into main Jan 15, 2025
8 checks passed
@softwarenerd softwarenerd deleted the feature/use-editor-action-bar-for-data-explorer branch January 15, 2025 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants