use correct reh/reh-web package.json in bundle #6028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue in which Positron Server doesn't start due to an error like this one:
The problem was caused by an incompletely merged line in the initial 1.95 merge, which caused a cascade of silent failures that led to
package.json
being omitted from thereh-web
bundle, which led to the above failure sincepackage.json
was responsible for setting"type": "module"
as noted above. The fix is just to update the line to match what it was before the merge:positron/build/gulpfile.reh.js
Lines 378 to 383 in fa567b2
Addresses, coincidentally, #5775, which is where this error was first spotted.
After the change, it ought to be possible to run
./positron-server
without error. E.g.: