Reticulate: Don't use bundled ipykernel #6400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
dfalbel
force-pushed
the
fix/reticulate-ipykernel
branch
from
f2b03dc to
de22c2a
Compare
seeM
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Reticulate, there's no way to control when the Python runtime will be started. It's possible that the Python runtime is started and only after some time it gets connected to Positron as a console. Thus there's no way to reliably modify
PYTHONPATHin order to use the bundled Ipykernel.With this PR, we special case kernels that might be using the
startKernelfunctionality. For those, we don't control the kernel startup, so setting the environment variable wont help.Adresses #6397
Release Notes
New Features
Bug Fixes
QA Notes
Start a reticulate session using a virtualenv that doesn't have ipykernel installed. Instead of using the bundled IPykernel, we should detect that it's not installed and offer a prompt to install it.
@:reticulate @:web