Dark theme fixes from Connect testing #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m--
approved these changes
Jan 11, 2025
| @@ -181,6 +181,11 @@ td code:not(.sourceCode) { | |||
| color: #ffffff; | |||
| } | |||
|
|
|||
| table caption code { | |||
| background-color: #6e768166 !important; | |||
There was a problem hiding this comment.
too bad the !importants are necessary here 🥲 no way to target these without them?
There was a problem hiding this comment.
Looks like I can remove the important for the table caption code - but not for inline code property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88
Screenshots for testing:
I also added backgrounds for the icons in "simple" appearance callouts in this PR to hold us over until we switch to brand.yml