Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(navsets): Add navsets kitchensink tests #1602

Merged
merged 21 commits into from
Aug 27, 2024
Merged

tests(navsets): Add navsets kitchensink tests #1602

merged 21 commits into from
Aug 27, 2024

Conversation

karangattu
Copy link
Collaborator

@karangattu karangattu commented Aug 1, 2024 •
edited
Loading

Also, address other open TODO items along the way

TODO:

@karangattu karangattu marked this pull request as ready for review August 1, 2024 15:02
@karangattu karangattu requested a review from schloerke August 1, 2024 15:03
@karangattu karangattu marked this pull request as draft August 2, 2024 12:18
@karangattu karangattu marked this pull request as ready for review August 22, 2024 11:38
schloerke and others added 9 commits August 22, 2024 14:31
@schloerke
Merge branch 'main' into address-todo-tasks
79719ed 
* main:
  refactor: `shiny create` and `shiny add test` supporting functions (#1629)
  Update CHANGELOG.md
  Fix #1601: Force text/javascript for .js files
@schloerke
Add sidebar test
6ac09b3
@schloerke
Add tabs for each of the navset bar tests
17c6b34
@schloerke @karangattu
Code review in person
01cdd55 
Add sidebar mixin
Add panel_value class parameter description
Add NavsetCardBase to init `.loc_sidebar` parameter
Put expect_position static-top to use a single expectation

Co-Authored-By: Karan <[email protected]>
@schloerke
Merge branch 'main' into address-todo-tasks
f5e196e
@karangattu
Add mixin for navset title
9ac7347
@karangattu
linting changes
f85d26b
@schloerke
bug: Add missing API support for `express.ui.navset_card_pill(placeme…
6132b3c 
…nt=)`
@schloerke
Add title to navset card controllers. Add placement mixin
743efcf
@schloerke schloerke enabled auto-merge (squash) August 23, 2024 18:40
@schloerke schloerke disabled auto-merge August 23, 2024 18:40
@schloerke schloerke enabled auto-merge (squash) August 23, 2024 18:45
@schloerke schloerke merged commit 769b36b into main Aug 27, 2024
48 checks passed
@schloerke schloerke deleted the address-todo-tasks branch August 27, 2024 19:27
@schloerke schloerke mentioned this pull request Sep 3, 2024
Closed
schloerke added a commit to machow/py-shiny that referenced this pull request Sep 5, 2024
@schloerke
Merge branch 'main' into machow-feat-narwhals
1155868 
* main:
  CI(deploy): Add more installation configs to surface failure cause (posit-dev#1658)
  `Chat.messages()` no longer trims messages by default (posit-dev#1657)
  tests(controllers): Split _controls.py into separate files (posit-dev#1652)
  Chat tweaks (posit-dev#1607)
  docs: Add modal_show/remove examples (posit-dev#1628)
  Delay sending of chat UI messages until reactive graph is flushed (posit-dev#1593)
  ci(remove future behavior warning): Set the `asyncio_default_fixture_loop_scope` to `fixture` (posit-dev#1655)
  bug: Verify mypy can run on CI (posit-dev#1650)
  Fix CI install failures on Windows (posit-dev#1651)
  Quartodoc 0.7.6 (posit-dev#1636)
  Allow `@chat.transform_assistant_response` function to return `None` (posit-dev#1641)
  feat: Support templates with `_template.json` metadata (posit-dev#1631)
  Fix KeyError when serving static files (posit-dev#1648)
  tests(navsets): Add navsets kitchensink tests (posit-dev#1602)
  Change default claude model to 3.5 sonnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karangattu @schloerke