Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1830

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Fix CI #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
70c3dab
Run CI
cpsievert Jan 28, 2025
33d6a3b
Handle google genai update to import
cpsievert Jan 28, 2025
a7eec3e
Fix autoreload typing issue
cpsievert Jan 28, 2025
6e42a18
Close #1829: pin langsmith
cpsievert Jan 28, 2025
e4eb0cb
Cleanup
cpsievert Jan 28, 2025
f531f83
Address code lint
cpsievert Jan 28, 2025
3698e9f
plotly now requires anywidget
cpsievert Jan 28, 2025
22a02b4
plotly now requires anywidget
cpsievert Jan 28, 2025
baf2106
Update pyproject.toml
cpsievert Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ test = [
"seaborn",
"plotnine",
"plotly",
"anywidget",
"duckdb",
"holoviews",
"bokeh",
Expand Down Expand Up @@ -116,6 +117,11 @@ dev = [
"anthropic",
"google-generativeai;python_version>='3.9'",
"langchain_core",
# langsmith (needed for langchain_core) versions >= 0.3
# (up to at least 0.3.2 as of 2025-01-29)
# cause an `argparse.ArgumentError` when running `pytest`.
# https://github.com/posit-dev/py-shiny/issues/1829
"langsmith<0.3",
"openai",
"ollama",
"tokenizers",
Expand Down
1 change: 0 additions & 1 deletion shiny/_autoreload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ async def process_request(
status_code=http.HTTPStatus.MOVED_PERMANENTLY,
reason_phrase="Moved Permanently",
headers=websockets.Headers(Location=app_url),
body=None,
Copy link
Collaborator Author

@cpsievert cpsievert Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type for body recently went from bytes | None to bytes

python-websockets/websockets@e6d0ea1

It seems we've always just wanted the default value for body anyway, so this seems safe to remove

)
else:
return None
Expand Down
1 change: 1 addition & 0 deletions tests/playwright/deploys/plotly/app_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pandas
plotly
anywidget
htmltools
git+https://github.com/posit-dev/py-shinywidgets.git#egg=shinywidgets

8 changes: 5 additions & 3 deletions tests/pytest/test_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def test_google_normalization():
if sys.version_info < (3, 9):
return

from google.generativeai import ( # pyright: ignore[reportMissingTypeStubs]
from google.generativeai.generative_models import ( # pyright: ignore[reportMissingTypeStubs]
GenerativeModel,
)

Expand Down Expand Up @@ -382,7 +382,7 @@ def test_as_google_message():
if sys.version_info < (3, 9):
return

from google.generativeai import ( # pyright: ignore[reportMissingTypeStubs]
from google.generativeai.generative_models import ( # pyright: ignore[reportMissingTypeStubs]
GenerativeModel,
)

Expand All @@ -403,7 +403,9 @@ def test_as_google_message():


def test_as_langchain_message():
from langchain_core.language_models.base import LanguageModelInput
from langchain_core.language_models.base import (
LanguageModelInput,
)
from langchain_core.language_models.base import (
Sequence as LangchainSequence, # pyright: ignore[reportPrivateImportUsage]
)
Expand Down
Loading