better route mappings

postare · Dec 1, 2023 · 8e01cc2 · 8e01cc2
1 parent c6ea156
commit 8e01cc2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -53,14 +53,15 @@ return [
      * to specify them, it is for obtaining a more user-friendly table.
      */
     'mappings' => [
-        'App\Models\Miogest\Property' => [
-            'type' => 'Immobile',
-            'pluralType' => 'Immobili',
-            'label' => 'ID: {id}',
-            'urlPrefix' => 'property',
-            'titleField' => 'titolo',
-            'slugField' => 'slug',
-        ],
+        //        EXAMPLE:
+        //        'App\Models\Property' => [
+        //            'type' => 'Property',
+        //            'pluralType' => 'Properties',
+        //            'label' => 'ID: {id}',
+        //            'titleField' => 'name',
+        //            'route' => 'property',
+        //            'record_identifier' => 'slug',
+        //        ],
     ],
 ];
 ```
@@ -140,10 +141,6 @@ Please see [CHANGELOG](CHANGELOG.md) for more information on what has changed re
 
 Please see [CONTRIBUTING](.github/CONTRIBUTING.md) for details.
 
-## Security Vulnerabilities
-
-Please review [our security policy](../../security/policy) on how to report security vulnerabilities.
-
 ## Credits
 
 - [Francesco Apruzzese](https://github.com/inerba)

diff --git a/config/contact-logs.php b/config/contact-logs.php
@@ -17,13 +17,14 @@
      * to specify them, it is for obtaining a more user-friendly table.
      */
     'mappings' => [
-        'App\Models\Miogest\Property' => [
-            'type' => 'Immobile',
-            'pluralType' => 'Immobili',
-            'label' => 'ID: {id}',
-            'urlPrefix' => 'property',
-            'titleField' => 'titolo',
-            'slugField' => 'slug',
-        ],
+        //        EXAMPLE:
+        //        'App\Models\Property' => [
+        //            'type' => 'Property',
+        //            'pluralType' => 'Properties',
+        //            'label' => 'ID: {id}',
+        //            'titleField' => 'name',
+        //            'route' => 'property',
+        //            'record_identifier' => 'slug',
+        //        ],
     ],
 ];
diff --git a/src/Resources/ContactLogResource.php b/src/Resources/ContactLogResource.php
@@ -63,11 +63,11 @@ public static function table(Table $table): Table
                 })
                 ->url(function ($record) {
                     // Ottieni la configurazione con un valore di default
-                    $urlPrefix = config("contact-logs.mappings.{$record->contactable_type}.urlPrefix");
-                    $slugField = config("contact-logs.mappings.{$record->contactable_type}.slugField");
+                    $route = config("contact-logs.mappings.{$record->contactable_type}.route");
+                    $record_identifier = config("contact-logs.mappings.{$record->contactable_type}.record_identifier");
 
-                    if ($urlPrefix && $slugField && $record->contactable) {
-                        return route($urlPrefix, $record->contactable->{$slugField});
+                    if ($route && $record_identifier && $record->contactable) {
+                        return route($route, $record->contactable->{$record_identifier});
                     }
 
                     return false;