Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten CONTRIBUTING.md #35

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Shorten CONTRIBUTING.md #35

merged 6 commits into from
Feb 23, 2024

Conversation

sthiele
Copy link
Member

@sthiele sthiele commented Feb 22, 2024

As discussed in Issue #33 a proposal for a much condensed CONTRIBUTING.md

@rkaminsk
Copy link
Member

rkaminsk commented Feb 22, 2024

Maybe we should have a vote which one to take? I personally don't care much.

Put 👀 for the old one and a 🎉 for the new one.

If you have strong arguments why one is better than the other drop some comments.

@javier-romero
Copy link

Hi, I have no experience at all on this so I won't vote, but I feel that:

  • in the template it is better to have the reduced version, since the other is overkill to me
  • it would still be good to have a link in the reduced version to the extended version (that should be somewhere accessible) since it can be useful to some people

@rkaminsk
Copy link
Member

Hi, I have no experience at all on this so I won't vote, but I feel that:

* in the template it is better to have the reduced version, since the other is overkill to me

I prefer short readmes. I think that for a contributing guide it is not as important to be concise.

Things to consider:

  • An experienced programmer is only interested in whether PRs are accepted and what form they should have. The short version tells him that PRs are accepted.
  • An inexperienced programmer does not get much information.
* it would still be good to have a link in the reduced version to the extended version (that should be somewhere accessible) since it can be useful to some people

So far we do not have a general contributing guide for the organization and I am not sure we should have one.

@rkaminsk
Copy link
Member

@sthiele what about this little extension?

@sthiele
Copy link
Member Author

sthiele commented Feb 23, 2024

@rkaminsk How about this?

@rkaminsk
Copy link
Member

Maybe we should also try to find a markdown auto formatter. I like to read markdown in my text editor.

@rkaminsk
Copy link
Member

@sthiele
Copy link
Member Author

sthiele commented Feb 23, 2024

Maybe we should also try to find a markdown auto formatter. I like to read markdown in my text editor.

I use https://github.com/DavidAnson/vscode-markdownlint.
It does not restrict line width ... my editor can do dynamic line wrapping 😛

@sthiele
Copy link
Member Author

sthiele commented Feb 23, 2024

Under the hood it uses https://github.com/DavidAnson/markdownlint-cli2

@rkaminsk
Copy link
Member

Maybe we should also try to find a markdown auto formatter. I like to read markdown in my text editor.

I use https://github.com/DavidAnson/vscode-markdownlint. It does not restrict line width ... my editor can do dynamic line wrapping 😛

Mine too. I just added mdformat and I like what it does. 😄

@rkaminsk rkaminsk merged commit 81ab612 into potassco:master Feb 23, 2024
3 checks passed
@sthiele sthiele deleted the patch-1 branch February 24, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants