Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasource][Resource] Add network security group ids field to network interface #193

Closed
wants to merge 5 commits into from

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Jan 27, 2025

Output from acceptance tests:

data source network interface

--- PASS: TestAccIBMPINetworkInterfaceDataSourceBasic (16.07s)
PASS

data source network interfaces

--- PASS: TestAccIBMPINetworkInterfacesDataSourceBasic (16.60s)
PASS

resource network interface

--- PASS: TestAccIBMPINetworkInterfaceBasic (23.25s)
PASS

--- PASS: TestAccIBMPINetworkInterfaceAllArgs (34.87s)
PASS

@ismirlia
Copy link
Collaborator Author

ismirlia commented Jan 27, 2025

network_security_group_id was missing from network_interface data sources documentation for whatever reason.

@ismirlia ismirlia force-pushed the ni-network-security-group-ids branch from cf47cdb to df1509a Compare January 27, 2025 20:45
@ismirlia ismirlia changed the title [Data source][Resource] Add network security group ids field to network interface [Datasource][Resource] Add network security group ids field to network interface Jan 27, 2025
michaelkad
michaelkad previously approved these changes Feb 3, 2025
@ismirlia
Copy link
Collaborator Author

Opened: IBM-Cloud#5993, closing this one.

@ismirlia ismirlia closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants