Add new API endpoints for forums and topics #11742
Open
+256
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements 3 endpoints: forum listing, single forum by id with topics, and topic listing
nanaya
requested changes
Feb 5, 2025
nanaya
requested changes
Feb 6, 2025
| if (is_api_request()) { | ||
| return [ | ||
| 'forums' => json_collection($forums, new ForumTransformer(), ['subforums.subforums']), | ||
| 'last_topics' => json_collection($lastTopics, new TopicTransformer()), |
There was a problem hiding this comment.
another one here. and maybe move the last topics query after this (and for the other one as well)
|
|
||
| return [ | ||
| 'forum' => json_item($forum, new ForumTransformer(), ['subforums.subforums']), | ||
| 'topics' => json_collection($topics, new TopicTransformer()), |
There was a problem hiding this comment.
need a ->get() here (or above, or combined here)
| 'new' => [ | ||
| // type 'timestamp' because the values are stored as integer in the database | ||
| ['column' => 'topic_last_post_time', 'order' => 'DESC', 'type' => 'timestamp'], | ||
| ['column' => 'topic_last_post_id', 'order' => 'DESC'], |
There was a problem hiding this comment.
this destroys performance due to no usable index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7440
It would be nice to have these available, and in my case, I want to automate some things on my otdb project by using the api to comb through the tournament forum. I would love to at least have the topic listing endpoint available if not the others.
Adds three endpoints: