Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ruleset variants in "best of" contests #11823

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Support ruleset variants in "best of" contests #11823

merged 1 commit into from
Jan 28, 2025

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jan 28, 2025 •
edited
Loading

Maybe? ಠ_ಠ

Add a variant field in the best_of object.

notbakaneko
notbakaneko approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 🤔
...also noticed it only considers existence of the playcount row and not if the value is actually > 0 but that's a different problem 👀

@notbakaneko notbakaneko merged commit f658d46 into ppy:master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
area:contests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko