Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wide angle check in wiggle bonus more lenient #31530

Open
wants to merge 2 commits into
base: pp-dev
Choose a base branch
from
Open

Make wide angle check in wiggle bonus more lenient #31530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f61b38
Update AimEvaluator.cs
Givikap120 Jan 15, 2025
6ba9e70
Merge branch 'pp-dev' into use_min_angle_in_wiggle
Givikap120 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion osu.Game.Rulesets.Osu/Difficulty/Evaluators/AimEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public static double EvaluateDifficultyOf(DifficultyHitObject current, bool with
{
double currAngle = osuCurrObj.Angle.Value;
double lastAngle = osuLastObj.Angle.Value;
double lastLastAngle = osuLastLastObj.Angle.Value;

// Rewarding angles, take the smaller velocity as base.
double angleBonus = Math.Min(currVelocity, prevVelocity);
Expand Down Expand Up @@ -102,7 +103,7 @@ public static double EvaluateDifficultyOf(DifficultyHitObject current, bool with
* DifficultyCalculationUtils.Smootherstep(currAngle, double.DegreesToRadians(110), double.DegreesToRadians(60))
* DifficultyCalculationUtils.Smootherstep(osuLastObj.LazyJumpDistance, radius, diameter)
* Math.Pow(DifficultyCalculationUtils.ReverseLerp(osuLastObj.LazyJumpDistance, diameter * 3, diameter), 1.8)
* DifficultyCalculationUtils.Smootherstep(lastAngle, double.DegreesToRadians(110), double.DegreesToRadians(60));
* DifficultyCalculationUtils.Smootherstep(Math.Min(lastAngle, lastLastAngle), double.DegreesToRadians(110), double.DegreesToRadians(60));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just makes the wiggle bonus potentially completely ignore the second angle no matter if its wide or acute. I don't think it makes any sense to be done like that in a acute wiggle bonus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should buff patterns like these without touching anything else
because the main effect of this line is not buffing angle changes on streams, what is still true with this change, because streams have many wide angles in a row
image

}
}

Expand Down
Loading