Adjust the behaviour of resolution number box in tournament client #32074
+194
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this is sane. The typical UX is to display a confirmation dialog post-change that requires the user to explicitly confirm they're OK with the change, and if no action is done withing about 20-30 seconds, the previous values are reverted to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a function to the number box of the resolution selector. When the
Enterkey is pressed with focus on the box, it would save and change the resolution as theSet Heightbutton does.After the new resolution is applied, a popup would appear for users to confirm the current resolution is what they'd expected.