Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collation #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions pfrl/utils/batch_states.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
from typing import Any, Callable, Sequence

from typing import Any, Callable, Dict, Optional, Sequence, Tuple, Type, Union

import copy
import numpy as np
import torch
from torch.utils.data._utils.collate import default_collate
from torch.utils.data._utils.collate import collate, default_collate_fn_map, np_str_obj_array_pattern


def collate_numpy_array_fn(batch, *, collate_fn_map: Optional[Dict[Union[Type, Tuple[Type, ...]], Callable]] = None):
"""Forked from: https://github.com/pytorch/pytorch/blob/main/torch/utils/data/_utils/collate.py#L216
"""
elem = batch[0]
# array of string classes and object
if np_str_obj_array_pattern.search(elem.dtype.str) is not None:
raise TypeError(default_collate_err_msg_format.format(elem.dtype))
return collate([torch.tensor(b) for b in batch], collate_fn_map=collate_fn_map)

pfrl_default_collate_fn_map = copy.deepcopy(default_collate_fn_map)
pfrl_default_collate_fn_map[np.ndarray] = collate_numpy_array_fn

def _to_recursive(batched: Any, device: torch.device) -> Any:
if isinstance(batched, torch.Tensor):
Expand All @@ -29,8 +44,7 @@ def batch_states(
the object which will be given as input to the model.
"""
features = [phi(s) for s in states]
# return concat_examples(features, device=device)
collated_features = default_collate(features)
collated_features = collate(features, collate_fn_map=pfrl_default_collate_fn_map)
if isinstance(features[0], tuple):
collated_features = tuple(collated_features)
return _to_recursive(collated_features, device)